[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add GPIO get function

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19159 )

Change subject: amd/pi/hudson: Add GPIO get function
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/19159/12/src/southbridge/amd/pi/hudson/Makefile.inc
File src/southbridge/amd/pi/hudson/Makefile.inc:

PS12, Line 42: $(CONFIG_SOUTHBRIDGE_AMD_PI_KERN)
Is there a reason not to always build it?


https://review.coreboot.org/#/c/19159/8/src/southbridge/amd/pi/hudson/gpio.h
File src/southbridge/amd/pi/hudson/gpio.h:

Line 28: #if IS_ENABLED(CONFIG_SOUTHBRIDGE_AMD_PI_KERN)
> Indeed, that would be a clearer name. So for my own benefit:
To be overly detailed, "hudson" was the codename for discrete controller hubs intended for APUs in 2-chip designs (first APUs were CPU/NB/Gfx).  The original variants were targeted at the mobile, desktop and embedded markets.  There were also good/better/best.  So you could get a Hudson D3 or Hudson E1.  About that same time, AMD decided they didn't like using codewords in public so documentation doesn't match up well without a decoder ring.
https://en.wikipedia.org/wiki/List_of_AMD_chipsets#Fusion_controller_hubs_.28FCH.29

I believe the only other discrete controller hub was called Bolton, also with variants for business segment and feature set.

There were also codenames given to the controller hubs inside the SOCs, e.g. Yangtze and Kern.

IMO the "hudson" naming in coreboot has always been somewhat improper and confusing.  And using codenames can be incomplete, e.g. if one name == another variant minus a few ports.

Finally, if memory serves...  The discrete FCHs were based on the SB800 (the SBxxx devices were part of 3-chip designs) and the internal FCHs in Family 16h based on SB900.  I don't have data for Kern in Family 15h.  So besides being confusing, we have multiple generations relying on somewhat common code.


-- 
To view, visit https://review.coreboot.org/19159
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f681865715ab947b525320a6f9fc63af1334b59
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes