[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add LPC IO decode enable function

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19160 )

Change subject: amd/pi/hudson: Add LPC IO decode enable function
......................................................................


Patch Set 16:

> We should just revert this as it appears vendorcode (and PI blob)
 > unconditionally overwrite WIDEIO0. We don't have full control of
 > that register.
 > 
 > It's the same code here:
 > git grep FCH_LPC_REG64 -- src/vendorcode
 > 
 > The use case:
 > https://review.coreboot.org/#/c/19164/13/src/mainboard/google/kahlee/ec.c
 > 
 > If I trace this all correctly manually, the particular LPC window
 > for EC would be lost while in AmdInitReset().


As documented, the developer should check that the setting is called and maintained. I have confirmed that this is not an issue on Stoney and not an issue if called after something else sets up some IO. 

We need a function that sets WIDEIO, so  we could mitigate this by assigning these in the reverse order, or always skipping WIDEIO0. Neither prevents the issue of multiple "owners/users". Other ideas?

-- 
To view, visit https://review.coreboot.org/19160
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bed3a99180188101e00b4431d634227e488cbda
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No