[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd/pi: Clarify CAR disable

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19269 )

Change subject: vendorcode/amd/pi: Clarify CAR disable
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19269/2/src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc
File src/vendorcode/amd/pi/00670F00/binaryPI/gcccar.inc:

Line 411: *   This CPU resume path doesn't use CAR, but be careful if porting to
> > No, not yet.  I suspect the firmware will have some involvement,
> Is the addition of this comment premature since it sounds like there is no s3 path yet?

I sort of think so, and recommend t.b.d.  In the event that HVB is a requirement for the PSP DRAM restore feature, surely that means we'll be taking a more traditional route on resume.


-- 
To view, visit https://review.coreboot.org/19269
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1265ed3d1bdf4b22f1a56f68bc53e18cfadc44b2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes