[coreboot-gerrit] Change in coreboot[master]: util: Add tools for dumping and inserting KBC1126 firmware i...

[Iru Cai (Code Review)]

Iru Cai has posted comments on this change. ( https://review.coreboot.org/19071 )

Change subject: util: Add tools for dumping and inserting KBC1126 firmware images.
......................................................................


Patch Set 2:

(3 comments)

I did a clang-format and added a README.

https://review.coreboot.org/#/c/19071/1/util/kbc1126/kbc1126_ec_dump.c
File util/kbc1126/kbc1126_ec_dump.c:

Line 1: /*
> Licence header
Done


PS1, Line 54: 
> No brackets for 1 line statements.
Done


PS1, Line 54: 
> spaces between operators. happens a lot.
Done


-- 
To view, visit https://review.coreboot.org/19071
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic521b177b9602ff042312cccaaa89371db7c5855
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes