[coreboot-gerrit] Change in coreboot[master]: nb/pineview/raminit: Don't do Jedec init on resume from S3
Martin Roth (Code Review)
gerrit at coreboot.org
Wed Apr 26 16:29:14 CEST 2017
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19425 )
Change subject: nb/pineview/raminit: Don't do Jedec init on resume from S3
......................................................................
nb/pineview/raminit: Don't do Jedec init on resume from S3
This is not needed.
Change-Id: Id19a00c1546b7a71d90aa8c7e43e6efde1e9fbbc
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19425
Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
M src/northbridge/intel/pineview/raminit.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kyösti Mälkki: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
build bot (Jenkins): Verified
diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c
index 330c912..cf6cbb9 100644
--- a/src/northbridge/intel/pineview/raminit.c
+++ b/src/northbridge/intel/pineview/raminit.c
@@ -2616,10 +2616,10 @@
if (si.boot_path != BOOT_PATH_RESUME) {
MCHBAR32(0x260) = MCHBAR32(0x260) | (1 << 27);
- }
- sdram_jedecinit(&si);
- PRINTK_DEBUG("Done MRS\n");
+ sdram_jedecinit(&si);
+ PRINTK_DEBUG("Done MRS\n");
+ }
sdram_misc(&si);
PRINTK_DEBUG("Done misc\n");
--
To view, visit https://review.coreboot.org/19425
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id19a00c1546b7a71d90aa8c7e43e6efde1e9fbbc
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list