[coreboot-gerrit] Change in coreboot[master]: ec: add support for KBC1126 in HP laptops

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19072 )

Change subject: ec: add support for KBC1126 in HP laptops
......................................................................


Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/19072/3/src/ec/hp/kbc1126/Makefile.inc
File src/ec/hp/kbc1126/Makefile.inc:

PS3, Line 28: 	$(KBC1126_EC_INSERT) $(obj)/coreboot.pre \
            : 		$(CONFIG_KBC1126_FW1) $(CONFIG_KBC1126_FW2) \
            : 		$(CONFIG_KBC1126_FW1_OFFSET) $(CONFIG_KBC1126_FW2_OFFSET)
Could FW2 overlap potentially coreboot binary?
Can cbfstool not insert stuff at an offset?


https://review.coreboot.org/#/c/19072/3/src/ec/hp/kbc1126/ec.c
File src/ec/hp/kbc1126/ec.c:

PS3, Line 80: {
no brackets for 1 line statement.


Line 112: 	if (send_kbd_command(cmd)<0)
spaces before and after operators


-- 
To view, visit https://review.coreboot.org/19072
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b16eb7e26303eda740f52d667dedb7cc04b4ef0
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes