[coreboot-gerrit] Change in coreboot[master]: util: Add tools for dumping and inserting KBC1126 firmware i...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19071 )

Change subject: util: Add tools for dumping and inserting KBC1126 firmware images.
......................................................................


Patch Set 1:

(7 comments)

Needs licence headers and some style fixes. A README would be nice.

https://review.coreboot.org/#/c/19071/1/util/kbc1126/kbc1126_ec_dump.c
File util/kbc1126/kbc1126_ec_dump.c:

Line 1: #include <stdio.h>
Licence header


PS1, Line 54:  {
No brackets for 1 line statements.


PS1, Line 54: !=
spaces between operators. happens a lot.


https://review.coreboot.org/#/c/19071/1/util/kbc1126/kbc1126_ec_insert.c
File util/kbc1126/kbc1126_ec_insert.c:

Line 12: 	if (fseek(fp, o, SEEK_END)!=0) {
spaces.


PS1, Line 20:  {
no brackets for 1 line statements.


Line 20: 	if (argc<6) {
spaces.


Line 30: 	if (fp==NULL || fw1==NULL || fw2==NULL) {
spaces.


-- 
To view, visit https://review.coreboot.org/19071
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic521b177b9602ff042312cccaaa89371db7c5855
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes