[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common FAST_SPI code

[Barnali Sarkar (Code Review)]

Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/18557 )

Change subject: soc/intel/common/block: Add Intel common FAST_SPI code
......................................................................


Patch Set 32:

(9 comments)

https://review.coreboot.org/#/c/18557/31/src/soc/intel/common/block/fast_spi/fast_spi.c
File src/soc/intel/common/block/fast_spi/fast_spi.c:

PS31, Line 42: -
> nit: extra space.
Done


PS31, Line 42: D
> nit: extra space.
Done


https://review.coreboot.org/#/c/18557/31/src/soc/intel/common/block/fast_spi/fast_spi_flash.c
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

PS31, Line 38: SUCCESS			= 0,
> Where is this used?
Its not used, hence removed


PS31, Line 39: E_TIMEOUT
> Where is this used?
Used this in wait_for_hwseq_xfer() function


PS31, Line 53: ctx->pci_dev = PCH_DEV_SPI;
             : }
             : 
> Why is spibar needed now?
Done


Line 75:  * is the signature and revision fields. HORD_JEDEC provides access to the
> extra new line
Done


PS31, Line 132: 
              : 		if (hsfsts & SPIBAR_HSFSTS_FDONE)
              : 			return SUCCESS;
> Ya. Looks like it. We can just call it directly from wait_for_hwseq_xfer().
Done


PS31, Line 161: 
> When the code was originally written I think there was a TODO that never go
Implemented Timeout code.


PS31, Line 337: nt fast_spi_flash_read_wpsr(u8 *sr)
              : {
> This can never be true. fast_get_spibar already has an assert.
Yes. Removed this code


-- 
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 32
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes