[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Update ODT config

[Ravishankar Sarawadi (Code Review)]

Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/19397 )

Change subject: soc/intel/apollolake: Update ODT config
......................................................................


Patch Set 7:

(4 comments)

https://review.coreboot.org/#/c/19397/7/src/soc/intel/apollolake/include/soc/meminit.h
File src/soc/intel/apollolake/include/soc/meminit.h:

Line 124: 	int ca_odt_config;
> This field is no longer being used? If you truly want to allow the board to
Done


https://review.coreboot.org/#/c/19397/3/src/soc/intel/apollolake/meminit.c
File src/soc/intel/apollolake/meminit.c:

Line 259: }
> Which bss? 
Done


https://review.coreboot.org/#/c/19397/7/src/soc/intel/apollolake/meminit.c
File src/soc/intel/apollolake/meminit.c:

Line 76: 	/* Set CAODT_A_B_HIGH_HIGH (bit 1). */
> Note that this is 40 ohm impedance for lpddr4 modules having both their ODT
Done


Line 80: 	cfg->Ch3_OdtConfig = 0x2;
> If you have an enum you should use it.
Done


-- 
To view, visit https://review.coreboot.org/19397
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2f7636b46492a9d08472a0752cdf1f86a72e15
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Freddy Paul <freddy.paul at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes