[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common FAST_SPI code

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18557 )

Change subject: soc/intel/common/block: Add Intel common FAST_SPI code
......................................................................


Patch Set 31:

(8 comments)

https://review.coreboot.org/#/c/18557/31/src/soc/intel/common/block/fast_spi/fast_spi.c
File src/soc/intel/common/block/fast_spi/fast_spi.c:

PS31, Line 42:  
nit: extra space.


PS31, Line 42:  
nit: extra space.


https://review.coreboot.org/#/c/18557/31/src/soc/intel/common/block/fast_spi/fast_spi_flash.c
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:

PS31, Line 38: E_NOT_IMPLEMENTED
Where is this used?


PS31, Line 39: E_TIMEOUT
Where is this used?


PS31, Line 53: void *spibar;
             : 
             : 	spibar = fast_spi_get_bar();
Why is spibar needed now?

ctx->mmio_base = (uintptr_t)fast_spi_get_bar();


PS31, Line 132: printk(BIOS_ERR, "SPI Transaction %s at flash offset %x.\n"
              : 			 "\tHSFSTS = 0x%08x\n",
              : 	       failure_reason, flash_addr, ctx->hsfsts_on_last_error);
I am wondering if we really need this function. It is just printing out one line and for that we are maintaining hsfsts_on_last_error in fast_spi_flash_ctx. Can we simply move this to wait_for_hwseq_xfer() and get rid of hsfsts_on_last_error?


PS31, Line 161: ret == E_TIMEOUT)
wait_for_hwseq_xfer never returns E_TIMEOUT.


PS31, Line 337: if (!ctx->mmio_base)
              : 		return -1;
This can never be true. fast_get_spibar already has an assert.


-- 
To view, visit https://review.coreboot.org/18557
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I046e3b30c8efb172851dd17f49565c9ec4cb38cb
Gerrit-PatchSet: 31
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati at intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes