[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Add memmap file

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18428 )

Change subject: amd/pi/00670F00: Add memmap file
......................................................................


Patch Set 17: Code-Review-2

> The use of "eventually" is interesting here. AFAICS, that code would be ready to give EARLY_CBMEM_INIT and RELOCATABLE_RAMSTAGE for all binaryPI boards today. It's likely end up abandoned if I am faced with having to fight on reverting non-operational verstage code submitted on stoney.

You seem to have read too much into "eventually".

In case it's not clear, I would really like to abandon
https://review.coreboot.org/#/c/18492 "Clarify CAR disable"
through
https://review.coreboot.org/#/c/18433 "Change to early cbmem init"
in this stack, and rebase the rest on top of your
https://review.coreboot.org/#/c/19347 "binaryPI: Enable EARLY_CBMEM_INIT"

Your patches after that are less in the critical for me, with respect to having a running system.

> ...reverting non-operational verstage code...

I don't know what you mean, but let's not have that discussion here.

> ...that code would be ready...
I think there still some comments outstanding.  I'll go through and flag them again.

-- 
To view, visit https://review.coreboot.org/18428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddaa8359536081752fb8e47e49f4d5958416620
Gerrit-PatchSet: 17
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No