[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Add CA ODT config to memory

[Ravishankar Sarawadi (Code Review)]

Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/19397 )

Change subject: soc/intel/apollolake: Add CA ODT config to memory
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19397/3/src/soc/intel/apollolake/meminit.c
File src/soc/intel/apollolake/meminit.c:

Line 259: 	cfg->Ch3_OdtConfig |= lpcfg->ca_odt_config;
> Why is this being OR'd? It should be the value we want and expect. But the 
Yes, ca_odt_config is getting set for SKU in it's memory.c file (https://review.coreboot.org/#/c/19449/1) which will be used here as final config value, hence OR'd.


-- 
To view, visit https://review.coreboot.org/19397
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2f7636b46492a9d08472a0752cdf1f86a72e15
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Freddy Paul <freddy.paul at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes