[coreboot-gerrit] Change in coreboot[master]: google/poppy: Enable PD MCU device

Shamile Khan (Code Review) gerrit at coreboot.org
Wed Apr 26 00:46:21 CEST 2017


Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19441

to look at the new patch set (#2).

Change subject: google/poppy: Enable PD MCU device
......................................................................

google/poppy: Enable PD MCU device

In order for PD charge events to properly notify the OS when a charger is
attached we need to enable the PD MCU device and event source from the EC.

Without this change the charging still happens, but the OS does not notice
and update the charge state icon in the Chrome OS UI.

BUG=b:35586577
BRANCH=none
TEST=On a poppy board that has the VBUS rework applied, plug in a charger to
either port and see charge status updated to indicate charging in the
power_supply_info tool and the Chrome OS UI.

Change-Id: I59dcfc1cb5d11841f56cac7f4ffe461c2f9ec52a
Signed-off-by: Shamile Khan <shamile.khan at intel.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/19441/2
-- 
To view, visit https://review.coreboot.org/19441
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59dcfc1cb5d11841f56cac7f4ffe461c2f9ec52a
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy at intel.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Kevin K Wong <kevin.k.wong at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list