[coreboot-gerrit] Change in coreboot[master]: purism/librem13: Enable support for M.2 NVMe

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19446 )

Change subject: purism/librem13: Enable support for M.2 NVMe
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19446/1//COMMIT_MSG
Commit Message:

PS1, Line 9: Enabled/Disabled
> Please use imperative mood in present tense.
Done


https://review.coreboot.org/#/c/19446/1/src/mainboard/purism/librem13/devicetree.cb
File src/mainboard/purism/librem13/devicetree.cb:

Line 56: 		device pci 1c.4 on  end # PCIe Port #5
> What happens if you leave it off?
the interface doesn't appear in lspci. Ports #5 and #6 were disabled before because they were thought to be unused, then I found port #6 was used for NVMe, and factory BIOS has both port #5 and #6 enabled, so I enabled them both in case #5 is used for something that we haven't thought of/tested yet. There is no hard done in leaving it on.


-- 
To view, visit https://review.coreboot.org/19446
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8058cbad3da651144545d588c0ae78c5f5e598ac
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes