[coreboot-gerrit] Change in coreboot[master]: google/poppy: Enable PD MCU device

[Shamile Khan (Code Review)]

Shamile Khan has posted comments on this change. ( https://review.coreboot.org/19441 )

Change subject: google/poppy: Enable PD MCU device
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19441/1/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h
File src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h:

PS1, Line 37: EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)
> why is this required?
I just tested after removing it it does not seem to be needed. What is the purpose of EC_HOST_EVENT_USB_CHARGER? By the way, this patch is a port of the Eve patch.


-- 
To view, visit https://review.coreboot.org/19441
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59dcfc1cb5d11841f56cac7f4ffe461c2f9ec52a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jagadish Krishnamoorthy <jagadish.krishnamoorthy at intel.com>
Gerrit-Reviewer: Jenny Tc <jenny.tc at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes