[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add LPC IO decode enable function

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19160 )

Change subject: amd/pi/hudson: Add LPC IO decode enable function
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19160/1/src/southbridge/amd/pi/hudson/early_setup.c
File src/southbridge/amd/pi/hudson/early_setup.c:

PS1, Line 184: assert
> No, by default, assert is NOT fatal.  It's a Kconfig option.
Right, That is what I meant to convey. Developer builds can catch the assert, production builds should continue. You don't want to fail in the field (which should never happen...)


PS1, Line 204: assert(0);
> As mentioned above, assert is not fatal by default, so it seems likely that
So why do we have assert? I made this consistent with other errors of this type in other chipsets. I don't think we would want to die here if too many resources were requested.

I see your point, but I don't think that this code is wrong.


-- 
To view, visit https://review.coreboot.org/19160
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bed3a99180188101e00b4431d634227e488cbda
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes