[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Add GPIO get function

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19159 )

Change subject: amd/pi/hudson: Add GPIO get function
......................................................................


Patch Set 12:

> Does it make sense to rename these to kern_gpio?  Or make a
 > subdirectory for kern specific files?  Does it make sense to
 > refactor or rename Hudson at this point with now at least 3
 > variants in the folder?

The gpio function isn't specific, just the registers. I think that the .h structure could be considered, but the big refactor would be to move to the soc/ structure and use the gpio lib. As noted in the comment, I think that could be in the future, but that disrupts a lot of things. I would prefer to do incremental change, merge this portion and attack architectural changes separately. Note, that there are additional cleanups further in the stack.

-- 
To view, visit https://review.coreboot.org/19159
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f681865715ab947b525320a6f9fc63af1334b59
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No