[coreboot-gerrit] Change in coreboot[master]: util/ectool: Dump ram by default

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19152 )

Change subject: util/ectool: Dump ram by default
......................................................................


util/ectool: Dump ram by default

According to the comment above the default should dump the EC ram,
though is never reached since the variable 'write_addr' is not 0, but
initialized at -1.

Also removes brackets around one line statement below if to make
checkpatch.pl happy.

Change-Id: I390996b253f2f20682cd9ab2d4f560de6eccfc57
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19152
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Alexander Couzens <lynxis at fe80.eu>
---
M util/ectool/ectool.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Alexander Couzens: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c
index 6d9668d..dcf1728 100644
--- a/util/ectool/ectool.c
+++ b/util/ectool/ectool.c
@@ -135,9 +135,8 @@
 	}
 
 	/* preserve default - dump_ram if nothing selected */
-	if (!dump_ram && !dump_idx && !dump_query && !write_addr) {
+	if (!dump_ram && !dump_idx && !dump_query && (write_addr == -1))
 		dump_ram = 1;
-	}
 
 	if (dump_ram) {
 		printf("EC RAM:\n");

-- 
To view, visit https://review.coreboot.org/19152
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I390996b253f2f20682cd9ab2d4f560de6eccfc57
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)