[coreboot-gerrit] Change in coreboot[master]: util/ectool: Fix timeout on sending EC command

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19151 )

Change subject: util/ectool: Fix timeout on sending EC command
......................................................................


util/ectool: Fix timeout on sending EC command

When setting output to verbose, it incorrectly reports that it times
out on every command.

TESTED on Thinkpad X60.

Change-Id: I24f05f0c165462d5ba2604c7e2fe139400683275
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19151
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Alexander Couzens <lynxis at fe80.eu>
---
M util/ectool/ec.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexander Couzens: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/util/ectool/ec.c b/util/ectool/ec.c
index 08b6b1b..53a5360 100644
--- a/util/ectool/ec.c
+++ b/util/ectool/ec.c
@@ -70,7 +70,7 @@
 		if ((timeout & 0xff) == 0)
 			debug(".");
 	}
-	if (timeout) {
+	if (!timeout) {
 		debug("Timeout while sending data 0x%02x to EC!\n", data);
 		// return -1;
 	}

-- 
To view, visit https://review.coreboot.org/19151
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24f05f0c165462d5ba2604c7e2fe139400683275
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)