[coreboot-gerrit] Change in coreboot[master]: Documentation: Add design doc on revising our stages

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19266 )

Change subject: Documentation: Add design doc on revising our stages
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19266/1/Documentation/technotes/2017-04-reconsidering-ramstage.md
File Documentation/technotes/2017-04-reconsidering-ramstage.md:

Line 76: make use of libpayload incrementally.
> I feel like this proposal is ignoring quite a few realities that seem funda
The main advantage of shuffling that stuff in the general direction of the payload is that the payload can decide what to do at which point in time.

A simple payload just does everything in order. A more complex payload could implement threading to speed up the boot process (eg. by doing signature checks, slow hardware initialization, table creation and waiting for user input in parallel).

As for code duplication, the idea is precisely to collect everything within libpayload for the benefit of payloads. There will be payloads that won't contribute (eg. seabios and GRUB2), but for these we can propose the stub payload that does what ramstage does right now. Tianocore probably won't contribute either, but they already have "everything".

And yes, so far the proposal ignores a bunch of things, and I have to admit I didn't have the complications on the radar that stem from S3 resume.

I'll fill in some more blanks.


-- 
To view, visit https://review.coreboot.org/19266
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25a2dc5cc45064cd69f8a0641eabfe8159ac08e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ronald Minnich <rminnich at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes