[coreboot-gerrit] Change in coreboot[master]: binaryPI: Disable CAR with empty stack

Marshall Dawson (Code Review) gerrit at coreboot.org
Tue Apr 25 00:22:21 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18525 )

Change subject: binaryPI: Disable CAR with empty stack
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/18525/5/src/cpu/amd/pi/romstage.c
File src/cpu/amd/pi/romstage.c:

PS5, Line 36: (u8)
Not sure if you meant to remove this


-- 
To view, visit https://review.coreboot.org/18525
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bac098099c1caffea181356c63924f4b5a93b54
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list