[coreboot-gerrit] Change in coreboot[master]: binaryPI: Enable EARLY_CBMEM_INIT

Marshall Dawson (Code Review) gerrit at coreboot.org
Tue Apr 25 00:20:34 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19347 )

Change subject: binaryPI: Enable EARLY_CBMEM_INIT
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19347/3/src/cpu/amd/pi/romstage.c
File src/cpu/amd/pi/romstage.c:

PS3, Line 50: stack_top
Does coreboot take a position on arithmetic with uintptr_t types?


-- 
To view, visit https://review.coreboot.org/19347
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0263af9561e0367bbbde4d5c3190039f4c3047a0
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list