[coreboot-gerrit] Change in coreboot[master]: mainboard/via*: Drop AMD car.h file

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19404 )

Change subject: mainboard/via*: Drop AMD car.h file
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19404/1/src/mainboard/bcom/winnetp680/romstage.c
File src/mainboard/bcom/winnetp680/romstage.c:

Line 76: void main(unsigned long bist)
> Missing asmlinkage here. Same for all boards.
asmlinkage doesn't have anything to do with amd/car.h on a via chipset.

I agree it should be fixed up, but this isn't the patch.


-- 
To view, visit https://review.coreboot.org/19404
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2b3cfb619cf831c7a677992ca03d5f42e5ffd1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes