[coreboot-gerrit] Change in coreboot[master]: mainboard: add support for lenovo x1 carbon gen 1
Alexander Couzens (Code Review)
gerrit at coreboot.org
Mon Apr 24 23:43:26 CEST 2017
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/16994
to look at the new patch set (#5).
Change subject: mainboard: add support for lenovo x1 carbon gen 1
......................................................................
mainboard: add support for lenovo x1 carbon gen 1
Based on Thinkpad x230
USB debug port is the left front usb port
open todos:
- use autoport to see if it generates differences to x230
- SPD based on inteltool for elpida
- missing samsung memory
- missing hynix memory
- test msata port if soldered
- use pins to differ 4gb and 8gb
- check if buttons doesn't work because of wrong acpi (middle mouse and
right mouse click of trackpad buttons doesnt work)
- native graphics init works but is somehow broken before linux (because of dts value?)
- check why device consumes more power (+ 3W while idle)
- check if thermal/power/freq MSR are different
- check if it's display backlight
- check how big is the consumption when turning display off
- enable pci/sata link power save
Thanks to Holger Levsen for the device.
Change-Id: I97c8e01a3ce0577d7dc9e8df7d33db3b155fe3d6
Tested-on: lenovo x1 carbon gen 1
Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
A src/mainboard/lenovo/x1_carbon_gen1/Kconfig
A src/mainboard/lenovo/x1_carbon_gen1/Kconfig.name
A src/mainboard/lenovo/x1_carbon_gen1/Makefile.inc
A src/mainboard/lenovo/x1_carbon_gen1/acpi/ec.asl
A src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl
A src/mainboard/lenovo/x1_carbon_gen1/acpi/superio.asl
A src/mainboard/lenovo/x1_carbon_gen1/acpi_tables.c
A src/mainboard/lenovo/x1_carbon_gen1/board_info.txt
A src/mainboard/lenovo/x1_carbon_gen1/cmos.default
A src/mainboard/lenovo/x1_carbon_gen1/cmos.layout
A src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
A src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl
A src/mainboard/lenovo/x1_carbon_gen1/gpio.c
A src/mainboard/lenovo/x1_carbon_gen1/hda_verb.c
A src/mainboard/lenovo/x1_carbon_gen1/mainboard.c
A src/mainboard/lenovo/x1_carbon_gen1/romstage.c
A src/mainboard/lenovo/x1_carbon_gen1/smihandler.c
A src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
A src/mainboard/lenovo/x1_carbon_gen1/spd/elpida.hex
A src/mainboard/lenovo/x1_carbon_gen1/thermal.h
20 files changed, 1,421 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/16994/5
--
To view, visit https://review.coreboot.org/16994
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c8e01a3ce0577d7dc9e8df7d33db3b155fe3d6
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list