[coreboot-gerrit] Change in coreboot[master]: nb/x4x: Disable IGD when external GPU is found

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18504 )

Change subject: nb/x4x: Disable IGD when external GPU is found
......................................................................


Patch Set 14:

(1 comment)

> (1 comment)
 > 
 > I have trouble to understand why IGD wouldn't work as secondary
 > with a
 > gfx card in the PEG slot, but would work with anything else in the
 > PEG
 > slot and a gfx card in another slot.

I'd expect it to work fine in both cases when IGD is secondary but not with NGI enabled. Should NGI simply not run if ggc & (1 << 1) as a fix/workaround to have both enabled?

Maybe in a follow up patch some more finegrained control over primary-secundary VGA device with nvram option can be implemented?

https://review.coreboot.org/#/c/18504/14/src/northbridge/intel/x4x/early_init.c
File src/northbridge/intel/x4x/early_init.c:

PS14, Line 88: 0x03
> This matches non-VGA devices too. Those wouldn't display anything.
so only for 0x0300 with >>8 left out?


-- 
To view, visit https://review.coreboot.org/18504
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac
Gerrit-PatchSet: 14
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes