[coreboot-gerrit] Change in coreboot[master]: binaryPI: Fix UMA calculations

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19346 )

Change subject: binaryPI: Fix UMA calculations
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19346/2/src/northbridge/amd/pi/ramtop.c
File src/northbridge/amd/pi/ramtop.c:

PS2, Line 20: 0x78
> Agreed, yet all of this is completely unfixable without new binaryPI builds
Also agree.  However this would require some rearchitecture (both native and binaryPI).  I haven't found a good indication in HW until the InitMid call in ramstage.  I infer that InitPost() is mostly about DRAM controller, and Memory controller to a smaller extent.


PS2, Line 20: 0x78
> It's still in the header files:
> Fch.h:#define...

OK


-- 
To view, visit https://review.coreboot.org/19346
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c375e5da0dfef6cef0c50272356cd32a87b1ff6
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes