[coreboot-gerrit] Change in coreboot[master]: mb/intel/d510mo: Hoop up ACPI_RESUME

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19416 )

Change subject: mb/intel/d510mo: Hoop up ACPI_RESUME
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/19416/4/src/mainboard/intel/d510mo/romstage.c
File src/mainboard/intel/d510mo/romstage.c:

PS4, Line 145: #if !IS_ENABLED(CONFIG_HAVE_ACPI_RESUME)
> Would it make more sense to only skip it if it's on the S3 resume path, rat
I think this function significantly slows down boot. I think this function is more meant as a debug function anyway.

fast_ram_check could be used instead, without those straps.


-- 
To view, visit https://review.coreboot.org/19416
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb1bfe711549aabb6e597bda22848988a7e9cbe
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes