[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm: Hide ACPI on unsupported platforms

Martin Roth (Code Review) gerrit at coreboot.org
Mon Apr 24 19:26:45 CEST 2017


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19374 )

Change subject: drivers/i2c/tpm: Hide ACPI on unsupported platforms
......................................................................


drivers/i2c/tpm: Hide ACPI on unsupported platforms

Depend on I2C_TPM to prevent showing the menu entry on systems
that do not have an I2C TPM installed.

Change-Id: I7cd647c9c7e9721eab96ab64b844a882f156ee68
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/19374
Tested-by: build bot (Jenkins)
Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
---
M src/drivers/i2c/tpm/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Philippe Mathieu-Daudé: Looks good to me, but someone else must approve
  Duncan Laurie: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/drivers/i2c/tpm/Kconfig b/src/drivers/i2c/tpm/Kconfig
index 32e5fb4..9e3a0aa 100644
--- a/src/drivers/i2c/tpm/Kconfig
+++ b/src/drivers/i2c/tpm/Kconfig
@@ -50,6 +50,7 @@
 	depends on I2C_TPM
 
 config DRIVER_I2C_TPM_ACPI
+	depends on I2C_TPM
 	bool "Generate I2C TPM ACPI device"
 	default y if ARCH_X86 && I2C_TPM
 	default n

-- 
To view, visit https://review.coreboot.org/19374
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7cd647c9c7e9721eab96ab64b844a882f156ee68
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list