[coreboot-gerrit] Change in coreboot[master]: x86/acpi: Use initialized VBIOS in VFCT table

Marshall Dawson (Code Review) gerrit at coreboot.org
Mon Apr 24 19:13:42 CEST 2017


Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19383

to look at the new patch set (#4).

Change subject: x86/acpi: Use initialized VBIOS in VFCT table
......................................................................

x86/acpi: Use initialized VBIOS in VFCT table

AMD VBIOS option ROMs often modify themselves during initialization.
Check for the presence of a VBIOS at 0xc0000 before populating the
VFCT table.  If a matching ROM is found, use it for the source of
the copy.

Tested on Gardenia (Stoney) variant by observing amdgpu driver's
dmesg output.

Change-Id: I5be7e1562bde51800c5b0e704c79812d85bcf362
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/device/pci_rom.c
1 file changed, 36 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/19383/4
-- 
To view, visit https://review.coreboot.org/19383
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5be7e1562bde51800c5b0e704c79812d85bcf362
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list