[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Don't add UMA when computing TOLUD

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18889 )

Change subject: nb/intel/gm45: Don't add UMA when computing TOLUD
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/18889/2/src/northbridge/intel/gm45/raminit.c
File src/northbridge/intel/gm45/raminit.c:

PS2, Line 1243: 
              : 
              : 
              : 
> You mean like a sparse enumeration? That would hide the options
I have not read through the rtc nvram accessor functions but would an invalid option (in this case the hidden option) not cause it be set at what is set in cmos.default?


-- 
To view, visit https://review.coreboot.org/18889
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I969ffe4a4aaa31dd7993dc6370ccae9e6865a1b1
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes