[coreboot-gerrit] Change in coreboot[master]: mb/sapphire/pureplatinumh61: Sanitize Kconfig

Nicola Corna (Code Review) gerrit at coreboot.org
Mon Apr 24 10:01:52 CEST 2017


Nicola Corna has posted comments on this change. ( https://review.coreboot.org/19354 )

Change subject: mb/sapphire/pureplatinumh61: Sanitize Kconfig
......................................................................


Patch Set 1: Code-Review+1

> (1 comment)

On this board there are 2 controllers with a debug port, one on the back and one on the internal connector, that's why I preferred to specify a default value.

A Kconfig comment seems the best option to me, but we should adopt it for all the boards (currently it is only sometimes noted on the wiki pages, which makes the debug for the newcomers difficult, as they have to guess the physical port by themselves).

-- 
To view, visit https://review.coreboot.org/19354
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11d1c7155bf1c7f9298f60638a6c2f3b128f3fe8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list