[coreboot-gerrit] Change in coreboot[master]: nb/pineview/raminit: Fix raminit failing on hot reset path

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Apr 22 20:02:18 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19337 )

Change subject: nb/pineview/raminit: Fix raminit failing on hot reset path
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/19337/4//COMMIT_MSG
Commit Message:

PS4, Line 9: On hot reset some thing ought not to run:
> Maybe:
ok


Line 15: TESTED on Intel d510mo.
> Did ram initialization always fail?
yes, much like the x4x raminit. (which at some point had an ugly hack issuing a cold reset before each boot to work around it)


-- 
To view, visit https://review.coreboot.org/19337
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f7e5c2958df29a96cdf856ade2f4f33707ad362
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list