[coreboot-gerrit] Change in coreboot[master]: cpu/intel/model_106cx: Add tsc_freq_mhz() function

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19067 )

Change subject: cpu/intel/model_106cx: Add tsc_freq_mhz() function
......................................................................


Patch Set 1:

(2 comments)

> (2 comments)
 > 
 > I'd rather see this in a common place. But if nobody has time for
 > this,
 > this should go in, I guess.

NB code? that would makes use of MCHBAR macro more easy?

https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/Makefile.inc
File src/cpu/intel/model_106cx/Makefile.inc:

PS1, Line 5: romstage-y += tsc_freq.c
           : smm-y      += tsc_freq.c
> Please remove...
ok


https://review.coreboot.org/#/c/19067/1/src/cpu/intel/model_106cx/tsc_freq.c
File src/cpu/intel/model_106cx/tsc_freq.c:

PS1, Line 29: 400
> Do we (coreboot) override BSEL anywhere? If not, should this
not possible with software, only hardware using for instance tape to cover up BSEL pins or this weird ASUS P5GC-MX that uses SIO gpio as BSEL pins.

Then again no board with this CPU has a socketed CPU so...


-- 
To view, visit https://review.coreboot.org/19067
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6074f3f097d7e6fc501a376754a05eb9e4faa0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes