[coreboot-gerrit] Change in coreboot[master]: mb/intel/d510mo: Hoop up ACPI_RESUME

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19416 )

Change subject: mb/intel/d510mo: Hoop up ACPI_RESUME
......................................................................


Patch Set 1:

> After you told that S3 path raminit behaves exactly like normal
 > boot, I am no longer convinced that all memory contents is
 > preserved properly.
 > 
 > AFAIK you need to avoid some part of training (write leveling?) on
 > S3 path.

Seems you are right. Jedec init needs not to be done on s3 resume.

DQS receiver enable training is being redone by vendor too so that does not need to be stored/restored I think.

Other than that this only implements ddr2 raminit so write leveling, read training are not implemented here. (There is some weird function about ZQCL in this raminit, probably ill named)

-- 
To view, visit https://review.coreboot.org/19416
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb1bfe711549aabb6e597bda22848988a7e9cbe
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No