[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Add memmap file

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18428 )

Change subject: amd/pi/00670F00: Add memmap file
......................................................................


Patch Set 12:

(1 comment)

I anticipate we'll get Kyosti's stack wrapped up that contains https://review.coreboot.org/#/c/19346 and use that one eventually.

https://review.coreboot.org/#/c/18428/12/src/northbridge/amd/pi/00670F00/memmap.c
File src/northbridge/amd/pi/00670F00/memmap.c:

Line 60: 		return 256 * MiB;
> So these are fixed sizes solely based on system memory? One can't use more 
These are the recommended sizes and not fixed in stone.  When coreboot tells the PI to use the AUTO setting, this is how it will determine how much to carve off.


-- 
To view, visit https://review.coreboot.org/18428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ddaa8359536081752fb8e47e49f4d5958416620
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes