[coreboot-gerrit] Change in coreboot[master]: mainboard/amd/gardenia: Remove PMxEE write on S4 resume

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18494 )

Change subject: mainboard/amd/gardenia: Remove PMxEE write on S4 resume
......................................................................


Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/18494/10/src/mainboard/amd/gardenia/romstage.c
File src/mainboard/amd/gardenia/romstage.c:

Line 43: 	outb(0xEE, PM_INDEX);
> I'm curious: in a later patch a TODO was added above this sequence. any rea
See revised change and commit message.  The documentation is lacking here.  I have a 5yo NDA doc and some modern sample code, so I think I understand what the intent was.  We can discuss offline if you want.


-- 
To view, visit https://review.coreboot.org/18494
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e6c5f7ad1de7f51b018543d2f7ce82182f11e4
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Zheng Bao <fishbaozi at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes