[coreboot-gerrit] Change in coreboot[master]: amd/pi: Add verstage support
Marshall Dawson (Code Review)
gerrit at coreboot.org
Sat Apr 22 03:06:29 CEST 2017
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/18439
to look at the new patch set (#17).
Change subject: amd/pi: Add verstage support
......................................................................
amd/pi: Add verstage support
This patch takes hints from the work in commits:
* 75c51d9 "x86: add standalone verstage support"
* 909c512 "fsp1_1: add verstage support"
Give PI-based systems the capability of running a SEPARATE_VERSTAGE.
This adds
* A verstage.c file to that initiates loading romstage (and verification)
* A new entry point in car.c that will be used when there is a separate
verstage
* Makefile flags and verstage-y additions for cpu and southbridge
* Besides AMD binary-PI changes, the x86 lapic timer is also now
included into verstage
This has been tested on Stoney (00670F000) and Gardenia. Although
additional APUs' makefiles are modified, none of those platforms are
assumed to support verstage at this time.
The AMD systems currently don't support C_ENVIRONMENT_BOOTBLOCK.
Once that has been added, portions of this patch can be backed out.
Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
(cherry picked from commit 15ce30cbd9d20aa0f5a5516e5f3bee7eab069852)
Change-Id: Ie43d87908c2d83b42b95b306419156e85993f7bd
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/cpu/amd/pi/00630F01/Makefile.inc
M src/cpu/amd/pi/00660F01/Makefile.inc
M src/cpu/amd/pi/00670F00/Makefile.inc
M src/cpu/amd/pi/00730F01/Makefile.inc
M src/cpu/amd/pi/Makefile.inc
M src/cpu/amd/pi/car.c
M src/cpu/amd/pi/car.h
A src/cpu/amd/pi/romstage_after_verstage.S
A src/cpu/amd/pi/verstage.c
M src/cpu/x86/lapic/Makefile.inc
M src/southbridge/amd/pi/hudson/Makefile.inc
M src/vendorcode/amd/pi/Makefile.inc
12 files changed, 73 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/18439/17
--
To view, visit https://review.coreboot.org/18439
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie43d87908c2d83b42b95b306419156e85993f7bd
Gerrit-PatchSet: 17
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
More information about the coreboot-gerrit
mailing list