[coreboot-gerrit] Change in coreboot[master]: cpu/amd/pi: Split CAR setup for use in multiple stages

Marshall Dawson (Code Review) gerrit at coreboot.org
Sat Apr 22 03:06:29 CEST 2017


Hello Kyösti Mälkki, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18437

to look at the new patch set (#17).

Change subject: cpu/amd/pi: Split CAR setup for use in multiple stages
......................................................................

cpu/amd/pi: Split CAR setup for use in multiple stages

This patch uses hints from commit e6af4be to make CAR setup more
standalone.  These changes will facilitate establishing CAR outside
of romstage in an upcoming separate verstage patch.  (e6af4be is
"intel fsp1_1: prepare for romstage vboot verification split".)

Move CAR teardown to its own file that will always be in romstage, but
isn't required in an earlier stage.

Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Reviewed-by: Marc Jones <marcj303 at gmail.com>
(cherry picked from commit c648d2a0f88ac1161f5d2002f7b947cb8e56b03f)

Change-Id: I9fe53ca1fd6b1edd4d5e072849f3962c8bc95df0
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/cpu/amd/pi/Makefile.inc
M src/cpu/amd/pi/cache_as_ram.inc
A src/cpu/amd/pi/exit_car.S
3 files changed, 51 insertions(+), 30 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/18437/17
-- 
To view, visit https://review.coreboot.org/18437
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9fe53ca1fd6b1edd4d5e072849f3962c8bc95df0
Gerrit-PatchSet: 17
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list