[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 IRQ s...

Julius Werner (Code Review) gerrit at coreboot.org
Fri Apr 21 22:58:52 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/19363 )

Change subject: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 IRQ status
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/19363/3/src/mainboard/google/reef/Kconfig
File src/mainboard/google/reef/Kconfig:

Line 35: config TPM_TIS_ACPI_INTERRUPT
> Done
Ah, right, didn't connect enough dots. This patch would've been fine, then.


-- 
To view, visit https://review.coreboot.org/19363
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004329eae1d8aabda51c46b8504bf210484782b4
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list