[coreboot-gerrit] Change in coreboot[master]: mainboard/google/reef: Add TPM_TIS_ACPI_INTERRUPT

Julius Werner (Code Review) gerrit at coreboot.org
Fri Apr 21 22:47:29 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/19408 )

Change subject: mainboard/google/reef: Add TPM_TIS_ACPI_INTERRUPT
......................................................................


Patch Set 1: Code-Review+2

(In my option there's no need to overdo the patch splitting like this, btw. I know Paul likes his separation but if you're changing the way a Kconfig is called in a driver I think it's perfectly fine to change all affected mainboards in the same patch. But since you've already done it we can also take it like this now.)

-- 
To view, visit https://review.coreboot.org/19408
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69add8a3ce35be64fb37db4ed40163f6144fc9c
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list