[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Align CA ODT settings

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/19397 )

Change subject: soc/intel/apollolake: Align CA ODT settings
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19397/1/src/soc/intel/apollolake/meminit.c
File src/soc/intel/apollolake/meminit.c:

PS1, Line 77: 	cfg->Ch0_OdtConfig = 2;
            : 	cfg->Ch1_OdtConfig = 2;
            : 	cfg->Ch2_OdtConfig = 2;
            : 	cfg->Ch3_OdtConfig = 2;
shouldn't this be per-board configurable?


-- 
To view, visit https://review.coreboot.org/19397
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2f7636b46492a9d08472a0752cdf1f86a72e15
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes