[coreboot-gerrit] Change in coreboot[master]: google/oak: Support cr50 over I2C on rowan

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19364 )

Change subject: google/oak: Support cr50 over I2C on rowan
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19364/2/src/mainboard/google/oak/Kconfig
File src/mainboard/google/oak/Kconfig:

Line 26: 	select TPM2
> but... it doesn't actually work.  I get build failures in vboot without out
Right. Tricky case. I reproduced and found the issue hidden in the build output:

 src/Kconfig:296:error: recursive dependency detected!
 src/Kconfig:296:        symbol MAINBOARD_HAS_TPM2 is selected by MAINBOARD_HAS_TPM_CR50
 src/Kconfig:408:        symbol MAINBOARD_HAS_TPM_CR50 depends on MAINBOARD_HAS_SPI_TPM_CR50
 src/drivers/spi/tpm/Kconfig:15: symbol MAINBOARD_HAS_SPI_TPM_CR50 depends on SPI_TPM
 src/drivers/spi/tpm/Kconfig:1:  symbol SPI_TPM depends on TPM2
 src/Kconfig:396:        symbol TPM2 is selected by MAINBOARD_HAS_TPM2

So the problem is: MAINBOARD_HAS_SPI_TPM_CR50 shouldn't depend on SPI_TPM. The former describes a capability of the board and the later is only on if we actually want to compile in the TPM code (cf. src/drivers/i2c/tpm/Kconfig:MAINBOARD_HAS_I2C_TPM_CR50 which also doesn't depend on SPI_TPM).

Would you mind sliding another patch for that into this series?


-- 
To view, visit https://review.coreboot.org/19364
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6cdd0e39e4ac86538f27f322c55c329179ee084
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes