[coreboot-gerrit] Change in coreboot[master]: AMD Geode: Move conflicting mainboard_romstage_entry()

Marc Jones (Code Review) gerrit at coreboot.org
Fri Apr 21 07:32:28 CEST 2017


Hello Kyösti Mälkki, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18769

to look at the new patch set (#9).

Change subject: AMD Geode: Move conflicting mainboard_romstage_entry()
......................................................................

AMD Geode: Move conflicting mainboard_romstage_entry()

The silicon specific mainboard_romstage_entry() in amd/cpu/car.h,
which is used by all AMD silicon car code, caused a conflict.
Move the silicon specific defines to silicon header files. Also,
no longer include car.h in the romstage file.

Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/include/cpu/amd/car.h
M src/include/cpu/amd/gx2def.h
M src/include/cpu/amd/lxdef.h
M src/mainboard/aaeon/pfm-540i_revb/romstage.c
M src/mainboard/amd/db800/romstage.c
M src/mainboard/amd/f2950/romstage.c
M src/mainboard/amd/norwich/romstage.c
M src/mainboard/amd/rumba/romstage.c
M src/mainboard/artecgroup/dbe61/romstage.c
M src/mainboard/digitallogic/msm800sev/romstage.c
M src/mainboard/iei/pm-lx-800-r11/romstage.c
M src/mainboard/lippert/frontrunner/romstage.c
M src/mainboard/lippert/hurricane-lx/romstage.c
M src/mainboard/lippert/literunner-lx/romstage.c
M src/mainboard/lippert/roadrunner-lx/romstage.c
M src/mainboard/lippert/spacerunner-lx/romstage.c
M src/mainboard/pcengines/alix1c/romstage.c
M src/mainboard/pcengines/alix2d/romstage.c
M src/mainboard/traverse/geos/romstage.c
M src/mainboard/winent/pl6064/romstage.c
M src/mainboard/wyse/s50/romstage.c
21 files changed, 2 insertions(+), 20 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/18769/9
-- 
To view, visit https://review.coreboot.org/18769
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Gerrit-PatchSet: 9
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list