[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Start Kahlee mainboard

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19161 )

Change subject: google/kahlee: Start Kahlee mainboard
......................................................................


Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/19161/7/src/mainboard/google/kahlee/acpi/carrizo_fch.asl
File src/mainboard/google/kahlee/acpi/carrizo_fch.asl:

PS7, Line 17: 	Name(_HID,"AAHB0000")
            : 	Name(_UID,0x0)
> Please add a space after the comma. Also further down.
This is a direct copy. This is fix later in the acpi cleanup patch. https://review.coreboot.org/#/c/19295/


-- 
To view, visit https://review.coreboot.org/19161
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfe100a5e303ccf89f973d9740075bd40ff3f18
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes