[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8173: Add EINT support

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19362 )

Change subject: mediatek/mt8173: Add EINT support
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19362/2/src/soc/mediatek/mt8173/include/soc/gpio.h
File src/soc/mediatek/mt8173/include/soc/gpio.h:

PS2, Line 129: During early boot
> Just say "In firmware". coreboot never enables interrupts on this platform.
Done


PS2, Line 130: pending the
> nit: "the pending"?
Done


-- 
To view, visit https://review.coreboot.org/19362
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d52591661a5a74ec1fd9a081f606f0a08a3a6ab
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes