[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8173: Add support for Dual DSI output

[Daniel Kurtz (Code Review)]

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/19361 )

Change subject: mediatek/mt8173: Add support for Dual DSI output
......................................................................


Patch Set 2: Code-Review-1

> Unfortunately you're making API changes to the SoC code so you have
 > to change mainboard code calling it at the same time. ;)
 > 
 > I usually don't see the splitting as strict as Paul... but I guess
 > you could do one change that only fixes the function signature in
 > mainboard/oak (passing 'false'), and another to add all the actual
 > Rowan stuff.

Duh. Of course.  I'll fix up that non-bisectable breakage and re-submit.

-- 
To view, visit https://review.coreboot.org/19361
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id47dfd7d9e98689b54398fc8d9142336b41dc29f
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No