[coreboot-gerrit] Change in coreboot[master]: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 IRQ s...

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19363 )

Change subject: drivers/i2c/tpm/cr50: Use tis_plat_irq_status for Cr50 IRQ status
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19363/1/src/drivers/i2c/tpm/tpm.h
File src/drivers/i2c/tpm/tpm.h:

PS1, Line 61: 	int irq;
> My understanding is the "if (chip->vendor.irq)" path is for the TPM 1.2 "co
Right. We're just asking you to kindly shave our yak for us while you're here anyway. ;) But you can leave it for someone else if you want.


https://review.coreboot.org/#/c/19363/2/src/mainboard/google/eve/Kconfig
File src/mainboard/google/eve/Kconfig:

PS2, Line 42: DRIVER_
TPM_TIS_ACPI_INTERRUPT, without the DRIVER_


-- 
To view, visit https://review.coreboot.org/19363
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004329eae1d8aabda51c46b8504bf210484782b4
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes