[coreboot-gerrit] Change in coreboot[master]: NOT_FOR_MERGE amd/pi/00670F00: fix up stack after verstage

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19358 )

Change subject: NOT_FOR_MERGE amd/pi/00670F00: fix up stack after verstage
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19358/1/src/cpu/amd/pi/romstage_after_verstage.S
File src/cpu/amd/pi/romstage_after_verstage.S:

Line 24: 	pushl	$0x0
> Why push? And'ing %esp will align down on its own.
yeah, that was dumb.  removing and squashing.


-- 
To view, visit https://review.coreboot.org/19358
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39bc33f87462ba47deec9637980a5344b7b39ac8
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes