[coreboot-gerrit] Change in coreboot[master]: AMD geode: Avoid conflicting mainboard_romstage_entry() decl...

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/18769 )

Change subject: AMD geode: Avoid conflicting mainboard_romstage_entry() declaration
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/18769/6/src/include/cpu/amd/car.h
File src/include/cpu/amd/car.h:

Line 6: #if IS_ENABLED(CONFIG_CPU_AMD_GEODE_LX) || IS_ENABLED(CONFIG_CPU_AMD_GEODE_GX2)
> In patchset 2 you said you were going to move the declaration entirely. Wha
I started to look at this and there wasn't an obvious good place to move it. The entry of the geode car doesn't match any of the pi agesa stuff and not so common even though they are all amd stuff is now including the /cpu/amd/car.h. I think that the original change was a bit premature in trying to combine things that don't really fit together, yet. 

The many changes to the pi car and the multiple board debugs have distracted from this. I don't have a good solution yet.


-- 
To view, visit https://review.coreboot.org/18769
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc759c4c93c8dfff76f5ef9a1a985dd704cfe94
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes