[coreboot-gerrit] Change in coreboot[master]: amd/pi/00670F00: Add tseg size to Kconfig

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19261 )

Change subject: amd/pi/00670F00: Add tseg size to Kconfig
......................................................................


Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/19261/6/src/cpu/amd/pi/00670F00/Kconfig
File src/cpu/amd/pi/00670F00/Kconfig:

PS6, Line 57: HAVE_SMI_HANDLER
> Are you expecting the mainboard to select this option?
It could be tbd. I think that's been the methodology in the past where SMI wasn't a requirement for basic functionality of the system.  It was mainly to give a value to be used here https://review.coreboot.org/#/c/18433/14/src/northbridge/amd/pi/00670F00/memmap.c

That approach may become OBE as it seems like there's some momentum toward Kyosti's conversion to early cbmem.


-- 
To view, visit https://review.coreboot.org/19261
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1ab23f37b2fdfce88a4b000ddeb5b947239587
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes